[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231125082601.GA84723@kernel.org>
Date: Sat, 25 Nov 2023 08:26:01 +0000
From: Simon Horman <horms@...nel.org>
To: Florian Westphal <fw@...len.de>
Cc: netfilter-devel@...r.kernel.org, lorenzo@...nel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH nf-next 1/8] netfilter: flowtable: move nf_flowtable out
of container structures
On Thu, Nov 23, 2023 at 03:10:51PM +0100, Florian Westphal wrote:
> Simon Horman <horms@...nel.org> wrote:
> > > - err = nf_flow_table_init(&ct_ft->nf_ft);
> > > + ct_ft->nf_ft = kzalloc(sizeof(*ct_ft->nf_ft), GFP_KERNEL);
> > > + if (!ct_ft->nf_ft)
> > > + goto err_alloc;
> >
> > Hi Florian,
> >
> > This branch will cause the function to return err, but err is 0 here.
> > Perhaps it should be set to a negative error value instead?
>
> Yes, this should fail with -ENOMEM.
Thanks, I will send a patch.
Powered by blists - more mailing lists