netdev - Re: [PATCH net-next] net: sfp: rework the RollBall PHY waiting code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a709db23-1b11-4818-babb-6e6dd74ae04d@lunn.ch>
Date: Sat, 25 Nov 2023 18:21:30 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Marek Behún <kabel@...nel.org>
Cc: netdev@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] net: sfp: rework the RollBall PHY waiting code

On Tue, Nov 21, 2023 at 06:20:24PM +0100, Marek Behún wrote:
> RollBall SFP modules allow the access to PHY registers only after a
> certain time has passed. Until then, the registers read 0xffff.
> 
> Currently we have quirks for modules where we need to wait either 25
> seconds or 4 seconds, but recently I got hands on another module where
> the wait is even shorter.
> 
> Instead of hardcoding different wait times, lets rework the code:
> - increase the PHY retry count to 25
> - when RollBall module is detected, increase the PHY retry time from
>   50ms to 1s
> 
> Signed-off-by: Marek Behún <kabel@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew