lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <65638d68.050a0220.17be1.86fe@mx.google.com> Date: Sun, 26 Nov 2023 19:24:37 +0100 From: Christian Marangi <ansuelsmth@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean <olteanv@...il.com>, David Epping <david.epping@...singlinkelectronics.com>, Harini Katakam <harini.katakam@....com>, "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [net-next PATCH 3/3] net: phy: add support for PHY package MMD read/write On Sun, Nov 26, 2023 at 07:14:52PM +0100, Andrew Lunn wrote: > On Sun, Nov 26, 2023 at 01:37:48AM +0100, Christian Marangi wrote: > > Some PHY in PHY package may require to read/write MMD regs to correctly > > configure the PHY package. > > > > Add support for these additional required function in both lock and no > > lock variant. > > You are assuming the PHY only supports C45 over C22. But what about > those PHYs which have native C45? And maybe don't have C22 at all? > > You should refactor the code of __phy_read_mmd() into a helper and use > it here. > Have to be honest here and chose the ""easy"" way. Was a little scared by all the complexity with mmd with C45 and C22... The idea was to add C22 support for now and if used by others extend the function. But I guess with the generic approach we are taking it's better to handle it now. Will update this in v2. -- Ansuel
Powered by blists - more mailing lists