lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJM55Z9e=vjGKNnmURN15mvXo2bVd3igBA-3puF9q7eh5hiP+A@mail.gmail.com> Date: Sun, 26 Nov 2023 22:10:57 +0100 From: Emil Renner Berthing <emil.renner.berthing@...onical.com> To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Emil Renner Berthing <kernel@...il.dk>, Samin Guo <samin.guo@...rfivetech.com>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Richard Cochran <richardcochran@...il.com>, Giuseppe Cavallaro <peppe.cavallaro@...com> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, kernel@...labora.com Subject: Re: [PATCH v2 12/12] [UNTESTED] riscv: dts: starfive: beaglev-starlight: Enable gmac Cristian Ciocaltea wrote: > The BeagleV Starlight SBC uses a Microchip KSZ9031RNXCA PHY supporting > RGMII-ID. > > TODO: Verify if manual adjustment of the RX internal delay is needed. If > yes, add the mdio & phy sub-nodes. Sorry for being late here. I've tested that removing the mdio and phy nodes on the the Starlight board works fine, but the rx-internal-delay-ps = <900> property not needed on any of my VisionFive V1 boards either. So I wonder why you need that on your board Also in the driver patch you add support for phy-mode = "rgmii-txid", but here you still set it to "rgmii-id", so which is it? You've alse removed the phy reset gpio on the Starlight board: snps,reset-gpios = <&gpio 63 GPIO_ACTIVE_LOW> Why? > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com> > --- > arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > index 7cda3a89020a..d3f4c99d98da 100644 > --- a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > +++ b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts > @@ -11,3 +11,8 @@ / { > model = "BeagleV Starlight Beta"; > compatible = "beagle,beaglev-starlight-jh7100-r0", "starfive,jh7100"; > }; > + > +&gmac { > + phy-mode = "rgmii-id"; > + status = "okay"; > +}; Lastly the phy-mode and status are the same for the VF1 and Starlight boards, so why can't these be set in the jh7100-common.dtsi? /Emil > -- > 2.42.0 >
Powered by blists - more mailing lists