lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6563c20e.050a0220.6de54.6c62@mx.google.com> Date: Sun, 26 Nov 2023 23:09:15 +0100 From: Christian Marangi <ansuelsmth@...il.com> To: Linus Walleij <linus.walleij@...aro.org> Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Tim Harvey <tharvey@...eworks.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH RFC] net: dsa: mv88e6xxx: Support LED control On Sun, Nov 26, 2023 at 09:11:28PM +0100, Linus Walleij wrote: > On Sun, Nov 26, 2023 at 5:45 PM Andrew Lunn <andrew@...n.ch> wrote: > > On Sun, Nov 26, 2023 at 12:46:03AM +0100, Linus Walleij wrote: > > > On Thu, Nov 23, 2023 at 5:13 PM Andrew Lunn <andrew@...n.ch> wrote: > > > > > > > What i would really like to see happen is that the DSA core handles > > > > the registration of the LEDs, similar to how phylib does. The DT > > > > binding should be identical for all DSA devices, so there is no need > > > > for each driver to do its own parsing. > > > > > > > > There are some WIP patches at > > > > > > > > https://github.com/lunn/linux.git leds-offload-support-reduced-auto-netdev > > > > > > > > which implement this. Feel free to make use of them. > > > > > > Oh it's quite a lot of patches, I really cannot drive that because there are > > > so many things about them that I don't understand the thinking behind... > > > But I like what I see! > > > > O.K. Let me dust them off, rebase them on net-next and see what is > > missing. > > Thanks Andrew, appreciated! > > I'll be happy to rebuild it on top of what you put as the baseline, > hopefully it will help Christian with the qca8k support as well? > Sure thing. I can test and see if I have problem with the generic approach. > > You have some fibre things i don't have. I don't have a > > machine with fibre so i cannot test that. > > I can test that, the way I check for its presence is through device tree looking > for an "sfp" phandle, AFAICT I don't see that the hardware can tell be > when there > is a fiber connected, but alas I don't have any datasheet. > > Yours, > Linus Walleij -- Ansuel
Powered by blists - more mailing lists