lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c51aa08d-944f-4d91-9cd0-c8a6ff6ceace@linaro.org> Date: Mon, 27 Nov 2023 11:57:08 +0100 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Siddh Raman Pant <code@...dh.me>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/4] nfc: llcp_sock_sendmsg: Reformat code to make the smaller block indented On 25/11/2023 21:26, Siddh Raman Pant wrote: > The block for datagram sending is a significantly bigger chunk of the > function compared to the other scenario. > > Thus, put the significantly smaller block inside the if-block. > > > + if (sk->sk_state != LLCP_BOUND) { > release_sock(sk); > - > - return nfc_llcp_send_ui_frame(llcp_sock, addr->dsap, addr->ssap, > - msg, len); > + return -ENOTCONN; > } > > - if (sk->sk_state != LLCP_CONNECTED) { > + DECLARE_SOCKADDR(struct sockaddr_nfc_llcp *, addr, msg->msg_name); No, this code is not readable. I don't think this change helps in anything. > + > + if (msg->msg_namelen < sizeof(*addr)) { > release_sock(sk); > - return -ENOTCONN; > + return -EINVAL; > } > > release_sock(sk); > > - return nfc_llcp_send_i_frame(llcp_sock, msg, len); > + return nfc_llcp_send_ui_frame(llcp_sock, addr->dsap, addr->ssap, > + msg, len); > + Stray blank line. Best regards, Krzysztof
Powered by blists - more mailing lists