netdev - Re: [PATCH 1/6] net: ravb: Check return value of reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 27 Nov 2023 12:49:29 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Claudiu <claudiu.beznea@...on.dev>, s.shtylyov@....ru,
 davem@...emloft.net,  edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, richardcochran@...il.com, 
 yoshihiro.shimoda.uh@...esas.com, geert+renesas@...der.be, 
 wsa+renesas@...g-engineering.com, robh@...nel.org,
 biju.das.jz@...renesas.com,  prabhakar.mahadev-lad.rj@...renesas.com,
 mitsuhiro.kimura.kc@...esas.com,  masaru.nagai.vx@...esas.com
Cc: netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Claudiu Beznea
 <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH 1/6] net: ravb: Check return value of
 reset_control_deassert()

On Mo, 2023-11-27 at 11:04 +0200, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> 
> reset_control_deassert() could return an error. Some devices cannot work
> if reset signal de-assert operation fails. To avoid this check the return
> code of reset_control_deassert() in ravb_probe() and take proper action.
> 
> Fixes: 0d13a1a464a0 ("ravb: Add reset support")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp