netdev - RE: [Intel-wired-lan] [PATCH iwl-net] ice: Restore fix disabling RX VLAN filtering

Open Source and information security mailing list archives

Date: Mon, 27 Nov 2023 12:39:36 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, Marcin Szycik
	<marcin.szycik@...ux.intel.com>
CC: "Drewek, Wojciech" <wojciech.drewek@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] ice: Restore fix disabling RX
 VLAN filtering

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Simon Horman
> Sent: Thursday, November 9, 2023 6:25 PM
> To: Marcin Szycik <marcin.szycik@...ux.intel.com>
> Cc: Drewek, Wojciech <wojciech.drewek@...el.com>;
> netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Restore fix disabling RX
> VLAN filtering
> 
> On Tue, Nov 07, 2023 at 02:51:38PM +0100, Marcin Szycik wrote:
> > Fix setting dis_rx_filtering depending on whether port vlan is being
> > turned on or off. This was originally fixed in commit c793f8ea15e3 ("ice:
> > Fix disabling Rx VLAN filtering with port VLAN enabled"), but while
> > refactoring ice_vf_vsi_init_vlan_ops(), the fix has been lost. Restore
> > the fix along with the original comment from that change.
> >
> > Also delete duplicate lines in ice_port_vlan_on().
> >
> > Fixes: 2946204b3fa8 ("ice: implement bridge port vlan")
> > Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> > Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives