netdev - Re: [patch net-next v4 8/9] devlink: add a command to set notification filter and use it for multicasts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWSSDpE9QtJmx1Nj@nanopsycho>
Date: Mon, 27 Nov 2023 13:56:46 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, jacob.e.keller@...el.com,
	jhs@...atatu.com, johannes@...solutions.net,
	andriy.shevchenko@...ux.intel.com, amritha.nambiar@...el.com,
	sdf@...gle.com, horms@...nel.org
Subject: Re: [patch net-next v4 8/9] devlink: add a command to set
 notification filter and use it for multicasts

Mon, Nov 27, 2023 at 01:51:03PM CET, jiri@...nulli.us wrote:
>Mon, Nov 27, 2023 at 01:30:04PM CET, przemyslaw.kitszel@...el.com wrote:
>>On 11/23/23 19:15, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@...dia.com>

[...]


>>>   static inline void devlink_nl_notify_send(struct devlink *devlink,
>>>   					  struct sk_buff *msg)
>>>   {
>>> -	genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink),
>>> -				msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL);
>>> +	struct devlink_obj_desc desc;
>>
>>`= {};` would wipe out the need for memset().
>
>True. If there is going to be a respin, I'll change this.

On a second thought, since the next patch adds couple more users of
devlink_nl_obj_desc_init(), I prefer to leave the zeroing there.


>
>
>>
>>> +
>>> +	devlink_nl_obj_desc_init(&desc, devlink);
>>> +	devlink_nl_notify_send_desc(devlink, msg, &desc);
>>>   }
>>>   /* Notify */
>>
>>[snip]