netdev - Re: [PATCH net-next 01/38] selftests/net: add lib.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fs0re3q8.fsf@nvidia.com>
Date: Mon, 27 Nov 2023 14:15:47 +0100
From: Petr Machata <petrm@...dia.com>
To: Hangbin Liu <liuhangbin@...il.com>
CC: Petr Machata <petrm@...dia.com>, <netdev@...r.kernel.org>, "David S.
 Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "Eric
 Dumazet" <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan
	<shuah@...nel.org>, David Ahern <dsahern@...nel.org>,
	<linux-kselftest@...r.kernel.org>, Po-Hsu Lin <po-hsu.lin@...onical.com>,
	Guillaume Nault <gnault@...hat.com>, Björn Töpel
	<bjorn@...osinc.com>, Ryan Roberts <ryan.roberts@....com>, Andrew Morton
	<akpm@...ux-foundation.org>, Mark Brown <broonie@...nel.org>, "Luis
 Chamberlain" <mcgrof@...nel.org>
Subject: Re: [PATCH net-next 01/38] selftests/net: add lib.sh


Hangbin Liu <liuhangbin@...il.com> writes:

> On Fri, Nov 24, 2023 at 03:05:18PM +0100, Petr Machata wrote:
>> 
>> Hangbin Liu <liuhangbin@...il.com> writes:
>> 
>> > +# Helpers
>> > +busywait()
>> > +{
>> > +	local timeout=$1; shift
>> > +
>> > +	local start_time="$(date -u +%s%3N)"
>> > +	while true
>> > +	do
>> > +		local out
>> > +		out=$($@)
>> > +		local ret=$?
>> > +		if ((!ret)); then
>> > +			echo -n "$out"
>> > +			return 0
>> > +		fi
>> > +
>> > +		local current_time="$(date -u +%s%3N)"
>> > +		if ((current_time - start_time > timeout)); then
>> > +			echo -n "$out"
>> > +			return 1
>> > +		fi
>> > +	done
>> > +}
>> 
>> This is lifted from forwarding/lib.sh, right? Would it make sense to
>
> Yes.
>
>> just source this new file from forwarding/lib.sh instead of copying
>
> Do you mean let net/forwarding/lib.sh source net.lib, and let other net
> tests source the net/forwarding/lib.sh?
>
> Or move the busywait() function from net/forwarding/lib.sh to net.lib.
> Then let net/forwarding/lib.sh source net.lib?

This.

>> stuff around? I imagine there will eventually be more commonality, and
>> when that pops up, we can just shuffle the forwarding code to
>> net/lib.sh.
>
> Yes, make sense.
>
> Thanks
> Hangbin