netdev - Re: [PATCH] bpf: declare bpf_sk_storage_get_cg_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9628533-52c8-b497-23ec-e373768a6243@iogearbox.net>
Date: Mon, 27 Nov 2023 15:20:32 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Ben Dooks <ben.dooks@...ethink.co.uk>, netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, sdf@...gle.com
Subject: Re: [PATCH] bpf: declare bpf_sk_storage_get_cg_sock_proto

On 11/22/23 9:13 AM, Ben Dooks wrote:
> The bpf_sk_storage_get_cg_sock_proto struct is exported from
> net/core/bpf_sk_storage.c but is not decalred in any header

nit: typo

> file. Fix the following sparse warning by adding it to the
> include/net/bpf_sk_storage.h header:
> 
> net/core/bpf_sk_storage.c:334:29: warning: symbol 'bpf_sk_storage_get_cg_sock_proto' was not declared. Should it be static

Please add Fixes tag and Cc author (sdf@...gle.com) as well as bpf@...r.kernel.org:

Fixes: f7c6cb1d9728 ("bpf: Expose socket storage to BPF_PROG_TYPE_CGROUP_SOCK")

> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
>   include/net/bpf_sk_storage.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/net/bpf_sk_storage.h b/include/net/bpf_sk_storage.h
> index 2926f1f00d65..043155810822 100644
> --- a/include/net/bpf_sk_storage.h
> +++ b/include/net/bpf_sk_storage.h
> @@ -22,6 +22,7 @@ extern const struct bpf_func_proto bpf_sk_storage_get_proto;
>   extern const struct bpf_func_proto bpf_sk_storage_delete_proto;
>   extern const struct bpf_func_proto bpf_sk_storage_get_tracing_proto;
>   extern const struct bpf_func_proto bpf_sk_storage_delete_tracing_proto;
> +extern const struct bpf_func_proto bpf_sk_storage_get_cg_sock_proto;
>   
>   struct bpf_local_storage_elem;
>   struct bpf_sk_storage_diag;
>