netdev - Re: [PATCH net-next v3 00/13] net: page_pool: add netlink-based introspection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231127065444.6ysqni5pt5jfnimf@google.com>
Date: Mon, 27 Nov 2023 06:54:44 +0000
From: Shakeel Butt <shakeelb@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, almasrymina@...gle.com, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, dsahern@...il.com, dtatulea@...dia.com, 
	willemb@...gle.com
Subject: Re: [PATCH net-next v3 00/13] net: page_pool: add netlink-based introspection

On Sun, Nov 26, 2023 at 02:43:00PM -0800, Jakub Kicinski wrote:
> On Sat, 25 Nov 2023 20:57:24 +0000 Shakeel Butt wrote:
> > > $ ./page-pool
> > >     eth0[2]	page pools: 10 (zombies: 0)
> > > 		refs: 41984 bytes: 171966464 (refs: 0 bytes: 0)
> > > 		recycling: 90.3% (alloc: 656:397681 recycle: 89652:270201)  
> > 
> > Hi Jakub, I am wondering if you considered to expose these metrics
> > through meminfo/vmstat as well, is that a bad idea or is this/netlink
> > more of a preference?
> 
> If that's net-namespaced we can add the basics there. We'll still need
> the netlink interface, tho, it's currently per-interface and per-queue
> (simplifying a bit). But internally the recycling stats are also
> per-CPU, which could be of interest at some stage.

Not really net-namespaced but rather system level stats in those
interfaces. Anyways if having system level makes sense then these stats
can be added later.