netdev - Re: [PATCH] net: make config lines follow common pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5a633a8fb4fa0d4375d90e7c3797b016f494711.camel@redhat.com>
Date: Mon, 27 Nov 2023 11:25:30 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Lukas Bulwahn <lukas.bulwahn@...il.com>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Simon Horman <horms@...ge.net.au>, Julian Anastasov
 <ja@....bg>,  Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik
 <kadlec@...filter.org>, Florian Westphal <fw@...len.de>, 
 netdev@...r.kernel.org, lvs-devel@...r.kernel.org, 
 netfilter-devel@...r.kernel.org, coreteam@...filter.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: make config lines follow common pattern

On Thu, 2023-11-23 at 12:12 +0100, Lukas Bulwahn wrote:
> The Kconfig parser is quite relaxed when parsing config definition lines.
> However, there are just a few config definition lines that do not follow
> the common regular expression 'config [0-9A-Z]', i.e., there are only a few
> cases where config is not followed by exactly one whitespace.
> 
> To simplify life for kernel developers that use basic regular expressions
> to find and extract kernel configs, make all config lines follow this
> common pattern.
> 
> No functional change, just helpful stylistic clean-up.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

IMHO this is a bit too much noise for a small gain: simple REs can
match all the existing patterns with 100% accuracy.

I think this should be dropped.

Cheers,

Paolo