netdev - Re: [PATCH bpf-next v3 0/2] Allow data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fcc90b1-deeb-487f-b6e6-c649bee2e8a8@kernel.org>
Date: Tue, 28 Nov 2023 11:26:59 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Larysa Zaremba <larysa.zaremba@...el.com>, bpf@...r.kernel.org
Cc: netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>,
 Magnus Karlsson <magnus.karlsson@...il.com>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Yunsheng Lin <linyunsheng@...wei.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 John Fastabend <john.fastabend@...il.com>,
 Aleksander Lobakin <aleksander.lobakin@...el.com>
Subject: Re: [PATCH bpf-next v3 0/2] Allow data_meta size > 32

On 11/27/23 19:32, Larysa Zaremba wrote:
> Currently, there is no reason for data_meta to be limited to 32 bytes.
> Loosen this limitation and make maximum meta size 252.

First I though you made a type here with 252 bytes, but then I 
remembered the 4 byte alignment.
I think commit message should elaborate on why 252 bytes.

> 
> Also, modify the selftest, so test_xdp_context_error does not complain
> about the unexpected success.
> 
> v2->v3:
> * Fix main patch author
> * Add selftests path
> 
> v1->v2:
> * replace 'typeof(metalen)' with the actual type
> 
> Aleksander Lobakin (1):
>    net, xdp: allow metadata > 32
> 
> Larysa Zaremba (1):
>    selftests/bpf: increase invalid metadata size
> 
>   include/linux/skbuff.h                              | 13 ++++++++-----
>   include/net/xdp.h                                   |  7 ++++++-
>   .../selftests/bpf/prog_tests/xdp_context_test_run.c |  4 ++--
>   3 files changed, 16 insertions(+), 8 deletions(-)
>