netdev - Re: [PATCH v2 net] r8169: prevent potential deadlock in rtl8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 28 Nov 2023 12:10:25 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 davem@...emloft.net, nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] r8169: prevent potential deadlock in rtl8169_close

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Sun, 26 Nov 2023 23:01:02 +0100 you wrote:
> ndo_stop() is RTNL-protected by net core, and the worker function takes
> RTNL as well. Therefore we will deadlock when trying to execute a
> pending work synchronously. To fix this execute any pending work
> asynchronously. This will do no harm because netif_running() is false
> in ndo_stop(), and therefore the work function is effectively a no-op.
> However we have to ensure that no task is running or pending after
> rtl_remove_one(), therefore add a call to cancel_work_sync().
> 
> [...]

Here is the summary with links:
  - [v2,net] r8169: prevent potential deadlock in rtl8169_close
    https://git.kernel.org/netdev/net/c/91d3d149978b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html