netdev - Re: [PATCH v2 net-next 5/8] tcp: Don't initialise tp->tsoffset in tcp_get_cookie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKpxMESKffzYuDwxdkrt2+LRLdbLTK+LVhVEZZLM1vRag@mail.gmail.com>
Date: Tue, 28 Nov 2023 16:17:04 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 5/8] tcp: Don't initialise tp->tsoffset in tcp_get_cookie_sock().

On Sat, Nov 25, 2023 at 2:19 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> When we create a full socket from SYN Cookie, we initialise
> tcp_sk(sk)->tsoffset redundantly in tcp_get_cookie_sock() as
> the field is inherited from tcp_rsk(req)->ts_off.
>
>   cookie_v[46]_check
>   |- treq->ts_off = 0
>   `- tcp_get_cookie_sock
>      |- tcp_v[46]_syn_recv_sock
>      |  `- tcp_create_openreq_child
>      |     `- newtp->tsoffset = treq->ts_off
>      `- tcp_sk(child)->tsoffset = tsoff
>
> Let's initialise tcp_rsk(req)->ts_off with the correct offset
> and remove the second initialisation of tcp_sk(sk)->tsoffset.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> Reviewed-by: Simon Horman <horms@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>