netdev - Re: [patch net-next v4 5/9] genetlink: introduce per-sock family private pointer storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWYSz87OfY_J8RYq@smile.fi.intel.com>
Date: Tue, 28 Nov 2023 18:18:23 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Jiri Pirko <jiri@...nulli.us>, kuba@...nel.org, pabeni@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, jacob.e.keller@...el.com,
	jhs@...atatu.com, johannes@...solutions.net,
	amritha.nambiar@...el.com, sdf@...gle.com, horms@...nel.org,
	netdev@...r.kernel.org
Subject: Re: [patch net-next v4 5/9] genetlink: introduce per-sock family
 private pointer storage

On Tue, Nov 28, 2023 at 01:30:51PM +0100, Przemek Kitszel wrote:
> On 11/23/23 19:15, Jiri Pirko wrote:

...

> > + * Returns: valid pointer on success, otherwise NULL.
> 
> since you are going to post next revision,
> 
> kernel-doc requires "Return:" section (singular form)
> https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation
> 
> for new code we should strive to fulfil the requirement
> (or piss-off someone powerful enough to change the requirement ;))

Interestingly that the script accepts plural for a few keywords.
Is it documented somewhere as deprecated?

-- 
With Best Regards,
Andy Shevchenko