netdev - [PATCH net-next v2 0/4] net: ethernet: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 Nov 2023 18:38:24 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Roger Quadros <rogerq@...nel.org>
Cc: Siddharth Vadapalli <s-vadapalli@...com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	netdev@...r.kernel.org,
	kernel@...gutronix.de,
	Ravi Gunasekaran <r-gunasekaran@...com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Rob Herring <robh@...nel.org>,
	Yunsheng Lin <linyunsheng@...wei.com>,
	Marek Majtyka <alardam@...il.com>,
	linux-omap@...r.kernel.org,
	Kumar Kartikeya Dwivedi <memxor@...il.com>,
	Stanislav Fomichev <sdf@...gle.com>,
	Simon Horman <horms@...nel.org>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Wei Fang <wei.fang@....com>,
	Nick Child <nnac123@...ux.ibm.com>,
	Christian Marangi <ansuelsmth@...il.com>
Subject: [PATCH net-next v2 0/4] net: ethernet: Convert to platform remove callback returning void

Hello,

in (implicit) v1 of this series
(https://lore.kernel.org/netdev/20231117091655.872426-1-u.kleine-koenig@pengutronix.de)
I tried to address the resource leaks in the three cpsw drivers. However
this is hard to get right without being able to test the changes. So
here comes a series that just converts all drivers below
drivers/net/ethernet to use .remove_new() and adds a comment about the
potential leaks for someone else to fix the problem.

See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.
The TL;DR; is to prevent bugs like the three noticed here.

Note this series results in no change of behaviour apart from improving
the error message for the three cpsw drivers from

	remove callback returned a non-zero value. This will be ignored.

to

	Failed to resume device (-ESOMETHING)

. 

Best regards
Uwe

Uwe Kleine-König (4):
  net: ethernet: ti: am65-cpsw: Convert to platform remove callback returning void
  net: ethernet: ti: cpsw: Convert to platform remove callback returning void
  net: ethernet: ti: cpsw-new: Convert to platform remove callback returning void
  net: ethernet: ezchip: Convert to platform remove callback returning void

 drivers/net/ethernet/ezchip/nps_enet.c   |  6 ++----
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 15 ++++++++++-----
 drivers/net/ethernet/ti/cpsw.c           | 15 ++++++++++-----
 drivers/net/ethernet/ti/cpsw_new.c       | 15 ++++++++++-----
 4 files changed, 32 insertions(+), 19 deletions(-)

base-commit: 8c87404c76c1911a7ec5b61bf3b2c3858cb95de1
-- 
2.42.0