netdev - Re: [PATCHv3 net-next 07/10] docs: bridge: add multicast doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a8e798d-3226-4a9b-b0e2-ddf5d863a649@gmail.com>
Date: Tue, 28 Nov 2023 20:15:59 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: "David S . Miller" <davem@...emloft.net>, David Ahern
 <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Ido Schimmel <idosch@...sch.org>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Roopa Prabhu <roopa@...dia.com>,
 Stephen Hemminger <stephen@...workplumber.org>,
 Florian Westphal <fw@...len.de>, Andrew Lunn <andrew@...n.ch>,
 Vladimir Oltean <olteanv@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 Marc Muehlfeld <mmuehlfe@...hat.com>
Subject: Re: [PATCHv3 net-next 07/10] docs: bridge: add multicast doc

On 11/28/2023 12:49 AM, Hangbin Liu wrote:
> Add multicast part for bridge document.
> 
> Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   Documentation/networking/bridge.rst | 55 +++++++++++++++++++++++++++++
>   1 file changed, 55 insertions(+)
> 
> diff --git a/Documentation/networking/bridge.rst b/Documentation/networking/bridge.rst
> index 764d44c93c65..956583d2a184 100644
> --- a/Documentation/networking/bridge.rst
> +++ b/Documentation/networking/bridge.rst
> @@ -161,6 +161,61 @@ on a bridge is disabled by default. After enabling VLAN filtering on a bridge,
>   it will start forwarding frames to appropriate destinations based on their
>   destination MAC address and VLAN tag (both must match).
>   
> +Multicast
> +=========
> +
> +The Linux bridge driver has multicast support allowing it to process Internet
> +Group Management Protocol (IGMP) or Multicast Listener Discovery (MLD)
> +messages, and to efficiently forward multicast data packets. The bridge
> +driver support IGMPv2/IGMPv3 and MLDv1/MLDv2.

nit: supports.

> +
> +Multicast snooping
> +------------------
> +
> +Multicast snooping is a networking technology that allows network switches
> +to intelligently manage multicast traffic within a local area network (LAN).
> +
> +The switch maintains a multicast group table, which records the association
> +between multicast group addresses and the ports where hosts have joined these
> +groups. The group table is dynamically updated based on the IGMP/MLD messages
> +received. With the multicast group information gathered through snooping, the
> +switch optimizes the forwarding of multicast traffic. Instead of blindly
> +broadcasting the multicast traffic to all ports, it sends the multicast
> +traffic based on the destination MAC address only to ports which have joined
> +the respective destination multicast group.

maybe s/joined/subscribed/g (throughout the whole document)? Other than 
that:

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian