netdev - Re: [PATCH net-next 0/5] igc: ethtool: Check VLAN TCI mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87leagstcs.fsf@kurt>
Date: Wed, 29 Nov 2023 12:15:47 +0100
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Vinicius Costa Gomes <vinicius.gomes@...el.com>, Jesse Brandeburg
 <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/5] igc: ethtool: Check VLAN TCI mask

On Tue Nov 28 2023, Vinicius Costa Gomes wrote:
> Kurt Kanzenbach <kurt@...utronix.de> writes:
>
>> Hi,
>>
>> currently it is possible to configure receive queue assignment using the VLAN
>> TCI field with arbitrary masks. However, the hardware only supports steering
>> either by full TCI or the priority (PCP) field. In case a wrong mask is given by
>> the user the driver will silently convert it into a PCP filter which is not
>> desired. Therefore, add a check for it.
>>
>> Patches #1 to #4 are minor things found along the way.
>>
>
> Some very minor things: patches 2,3 and 4 have extra long lines in their
> commit messages that checkpatch.pl doesn't seem to like.

OK. checkpatch wants 75 chars per line. These patches have 80 set. I'll
adjust it.

>
> Patches 4 and 5 read more like fixes to me. I think they could be
> proposed to -net, as they contain fixes to user visible issues. Do you
> think that makes sense?

Probably yes. I'll sent them to -net instead. Fixes tags would be:

 - Patch 4: 2b477d057e33 ("igc: Integrate flex filter into ethtool ops")
 - Patch 5: 7991487ecb2d ("igc: Allow for Flex Filters to be installed")

>
> As for the code, feel free to add my Ack to the series:
>
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
>

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)