netdev - Re: [net-next] net: ethernet: renesas: rcar_gen4_ptp: Depend on PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <70eb5bdc-94b6-4b54-b578-13e66a69c962@app.fastmail.com>
Date: Wed, 29 Nov 2023 13:01:55 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: 
 Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>,
 "Richard Cochran" <richardcochran@...il.com>, Netdev <netdev@...r.kernel.org>
Cc: Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [net-next] net: ethernet: renesas: rcar_gen4_ptp: Depend on PTP_1588_CLOCK

On Wed, Nov 29, 2023, at 12:11, Niklas Söderlund wrote:
> When breaking out the Gen4 gPTP support to its own module the dependency
> on the PTP_1588_CLOCK framework was left as optional and only stated for
> the driver using the module. This leads to issues when doing
> COMPILE_TEST of RENESAS_GEN4_PTP separately and PTP_1588_CLOCK is built
> as a module and the other as a built-in. Add an explicit depend on
> PTP_1588_CLOCK.
>
> While at it remove the optional support for PTP_1588_CLOCK from
> RENESAS_ETHER_SWITCH as the driver unconditionally calls the Gen4 gPTP
> module and thus also requires the PTP_1588_CLOCK framework.
>
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 8c1c66235e03 ("net: ethernet: renesas: rcar_gen4_ptp: Break out 
> to module")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

Reviewed-by: Arnd Bergmann <arnd@...db.de>

Ideally someone should rework the driver (and the ravb one) to actually
leave out all the ptp related code when PTP is disabled, but this patch
avoids both the link failure and the possible logic issues for the moment.

     Arnd