netdev - Re: [PATCH 1/3] ss: prevent "Process" column from being printed unless requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b41c7f20-34f4-4644-9e7a-a94cc47a8228@gmail.com>
Date: Tue, 28 Nov 2023 17:20:13 -0700
From: David Ahern <dsahern@...il.com>
To: Quentin Deslandes <qde@...cy.de>, netdev@...r.kernel.org
Cc: Martin KaFai Lau <martin.lau@...nel.org>
Subject: Re: [PATCH 1/3] ss: prevent "Process" column from being printed
 unless requested

On 11/27/23 7:30 PM, Quentin Deslandes wrote:
> Commit 5883c6eba517 ("ss: show header for --processes/-p") added
> "Process" to the list of columns printed by ss. However, the "Process"
> header is now printed even if --processes/-p is not used.
> 
> This change aims to fix this by moving the COL_PROC column ID to the same
> index as the corresponding column structure in the columns array, and
> enabling it if --processes/-p is used.
> 
> Signed-off-by: Quentin Deslandes <qde@...cy.de>
> ---
>  misc/ss.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/misc/ss.c b/misc/ss.c
> index 9438382b..09dc1f37 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -100,8 +100,8 @@ enum col_id {
>  	COL_SERV,
>  	COL_RADDR,
>  	COL_RSERV,
> -	COL_EXT,
>  	COL_PROC,
> +	COL_EXT,
>  	COL_MAX
>  };
>  
> @@ -5795,6 +5795,9 @@ int main(int argc, char *argv[])
>  	if (ssfilter_parse(&current_filter.f, argc, argv, filter_fp))
>  		usage();
>  
> +	if (!show_processes)
> +		columns[COL_PROC].disabled = 1;
> +
>  	if (!(current_filter.dbs & (current_filter.dbs - 1)))
>  		columns[COL_NETID].disabled = 1;
>  

this one should go into main as a bug fix. Resubmit as a standalone
patch with:

Fixes: 5883c6eba517 ("ss: show header for --processes/-p")