netdev - Re: [PATCH iwl-next] ice: Rename E822 to E82X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231129164551.GE43811@kernel.org>
Date: Wed, 29 Nov 2023 16:45:51 +0000
From: Simon Horman <horms@...nel.org>
To: Karol Kolacinski <karol.kolacinski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	anthony.l.nguyen@...el.com, jesse.brandeburg@...el.com,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-next] ice: Rename E822 to E82X

On Fri, Nov 24, 2023 at 12:45:55PM +0100, Karol Kolacinski wrote:
> When code is applicable for both E822 and E823 devices, rename it from
> E822 to E82X.
> ICE_PHY_PER_NAC_E822 was unused, so just remove it.
> 
> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

Hi Karol,

while I think this naming scheme may have some shortcomings
if other E82[0-9] chips come along with different overlap
in function re-use, I also do see that it is a convenient
shorthand. And moreover that it matches what is already in-tree
as of at least:

88c360e49f51 ("ice: Support cross-timestamping for E823 devices")

So, FWIIW, beyond my mumblings here I am happy with this patch.

Reviewed-by: Simon Horman <horms@...nel.org>