lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 29 Nov 2023 18:02:03 +0100
From: Eric Dumazet <>
To: Dmitry Safonov <>
Cc: David Ahern <>, Paolo Abeni <>, 
	Jakub Kicinski <>, "David S. Miller" <>,, 
	Dmitry Safonov <>, Francesco Ruggeri <>, 
	Salam Noureddine <>, Simon Horman <>,
Subject: Re: [PATCH v4 2/7] net/tcp: Consistently align TCP-AO option in the header

On Wed, Nov 29, 2023 at 5:57 PM Dmitry Safonov <> wrote:
> Currently functions that pre-calculate TCP header options length use
> unaligned TCP-AO header + MAC-length for skb reservation.
> And the functions that actually write TCP-AO options into skb do align
> the header. Nothing good can come out of this for ((maclen % 4) != 0).
> Provide tcp_ao_len_aligned() helper and use it everywhere for TCP
> header options space calculations.
> Fixes: 1e03d32bea8e ("net/tcp: Add TCP-AO sign to outgoing packets")
> Signed-off-by: Dmitry Safonov <>

Reviewed-by: Eric Dumazet <>

Powered by blists - more mailing lists