lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231129194028.GH43811@kernel.org> Date: Wed, 29 Nov 2023 19:40:28 +0000 From: Simon Horman <horms@...nel.org> To: Andrew Lunn <andrew@...n.ch> Cc: netdev <netdev@...r.kernel.org>, Linus Walleij <linus.walleij@...aro.org>, Christian Marangi <ansuelsmth@...il.com>, Vladimir Oltean <vladimir.oltean@....com>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [PATCH RFC net-next 4/8] dsa: Create port LEDs based on DT binding On Wed, Nov 29, 2023 at 12:21:31AM +0100, Andrew Lunn wrote: ... > +static int dsa_port_leds_setup(struct dsa_port *dp) > +{ > + struct device_node *leds, *led; > + int err; > + > + if (!dp->dn) > + return 0; > + > + leds = of_get_child_by_name(dp->dn, "leds"); > + if (!leds) > + return 0; > + > + for_each_available_child_of_node(leds, led) { > + err = dsa_port_led_setup(dp, led); > + if (err) > + return err; Hi Andrew, I realise this is an RFC, but Coccinelle tells me that a call to of_node_put() is needed here. > + } > + > + return 0; > +} ...
Powered by blists - more mailing lists