netdev - Re: [PATCH] rhashtable: Better error message on allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231128173536.35ff7e9c@kernel.org>
Date: Tue, 28 Nov 2023 17:35:36 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: David Laight <David.Laight@...LAB.COM>
Cc: 'Kent Overstreet' <kent.overstreet@...ux.dev>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, Thomas Graf <tgraf@...g.ch>, Herbert Xu
 <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] rhashtable: Better error message on allocation failure

On Sat, 25 Nov 2023 15:23:49 +0000 David Laight wrote:
> > +	new_tbl = bucket_table_alloc(ht, size, GFP_KERNEL|__GFP_NOWARN);
> > +	if (new_tbl == NULL) {
> > +		WARN("rhashtable bucket table allocation failure for %ps",  
> 
> Won't WARN() be a panic on systems with PANICK_ON_WARN set?

Yes, that's problematic :(
Let's leave out the GFP_NOWARN and add a pr_warn() instead of
the WARN()?