netdev - Re: [PATCH RFC net-next 0/8] DSA LED infrastructure, mv88e6xxx and QCA8K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 Nov 2023 02:57:11 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev <netdev@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH RFC net-next 0/8] DSA LED infrastructure, mv88e6xxx and
 QCA8K

On Wed, Nov 29, 2023 at 12:21:27AM +0100, Andrew Lunn wrote:
> This patchset extends the DSA core to add support for port LEDs being
> controlled via sys/class/leds, and offloading blinking via
> ledtrig-netdev. The core parses the device tree binding, and registers
> LEDs. The DSA switch ops structure is extended with the needed
> functions.
> 
> The mv88e6xxx support is partially added. Support for setting the
> brightness and blinking is provided, but offloading of blinking is not
> yet available. To demonstrate this, the wrt1900ac device tree is
> extended with LEDs.
> 
> The existing QCA8K code is refactored to make use of this shared code.
> 
> RFC:
> 
> Linus, can you rework your code into this for offloading blinking ?
> And test with ports 5 & 6.
> 
> Christian: Please test QCA8K. I would not be surprised if there is an
> off-by-one.

Good news! I tested this and with the requested change, the thing works
correctly.

> 
> This code can also be found in
> 
> https://github.com/lunn/ v6.7-rc2-net-next-mv88e6xxx-leds
> 
> Andrew Lunn (8):
>   net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness
>   net: dsa: mv88e6xxx: Tie the low level LED functions to device ops
>   net: dsa: Plumb LED brightnes and blink into switch API
>   dsa: Create port LEDs based on DT binding
>   dsa: Plumb in LED calls needed for hardware offload
>   dsa: mv88e6xxx: Plumb in LED offload functions
>   arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs
>   dsa: qca8k: Use DSA common code for LEDs
> 
>  .../dts/marvell/armada-xp-linksys-mamba.dts   |  66 +++++
>  drivers/net/dsa/mv88e6xxx/chip.c              | 103 +++++++
>  drivers/net/dsa/mv88e6xxx/chip.h              |  14 +
>  drivers/net/dsa/mv88e6xxx/port.c              |  99 +++++++
>  drivers/net/dsa/mv88e6xxx/port.h              |  76 +++++-
>  drivers/net/dsa/qca/qca8k-8xxx.c              |  11 +-
>  drivers/net/dsa/qca/qca8k-leds.c              | 255 +++---------------
>  drivers/net/dsa/qca/qca8k.h                   |   9 -
>  drivers/net/dsa/qca/qca8k_leds.h              |  21 +-
>  include/net/dsa.h                             |  17 ++
>  net/dsa/dsa.c                                 | 190 +++++++++++++
>  11 files changed, 620 insertions(+), 241 deletions(-)
> 
> -- 
> 2.42.0
> 

-- 
	Ansuel