netdev - Re: [PATCH net-next v2 3/4] net: ethernet: ti: cpsw-new: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <565b6b26-eb6e-4fd2-b815-65273234136d@kernel.org>
Date: Thu, 30 Nov 2023 11:37:33 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Siddharth Vadapalli <s-vadapalli@...com>,
 Ravi Gunasekaran <r-gunasekaran@...com>,
 Kumar Kartikeya Dwivedi <memxor@...il.com>,
 Stanislav Fomichev <sdf@...gle.com>, Marek Majtyka <alardam@...il.com>,
 Simon Horman <horms@...nel.org>, Rob Herring <robh@...nel.org>,
 Yunsheng Lin <linyunsheng@...wei.com>, linux-omap@...r.kernel.org,
 netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next v2 3/4] net: ethernet: ti: cpsw-new: Convert to
 platform remove callback returning void

On 28/11/2023 19:38, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Replace the error path returning a non-zero value by an error message
> and a comment that there is more to do. With that this patch results in
> no change of behaviour in this driver apart from improving the error
> message.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Roger Quadros <rogerq@...nel.org>