lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <319ca57a-c89b-ba37-c5ca-e1eafc73392f@linux.alibaba.com> Date: Thu, 30 Nov 2023 19:02:06 +0800 From: Wen Gu <guwen@...ux.alibaba.com> To: Wenjia Zhang <wenjia@...ux.ibm.com>, wintera@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, kgraul@...ux.ibm.com, jaka@...ux.ibm.com Cc: borntraeger@...ux.ibm.com, svens@...ux.ibm.com, alibuda@...ux.alibaba.com, tonylu@...ux.alibaba.com, raspl@...ux.ibm.com, schnelle@...ux.ibm.com, linux-s390@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v2 1/7] net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity On 2023/11/29 20:50, Wenjia Zhang wrote: > > > On 24.11.23 15:42, Wen Gu wrote: >> Rename some smc_clc_first_contact_ext_v2x type variables to 'fce_v2x' >> to distinguish them from smc_clc_first_contact_ext type variables. >> >> Signed-off-by: Wen Gu <guwen@...ux.alibaba.com> >> --- >> net/smc/smc_clc.c | 26 +++++++++++++------------- >> 1 file changed, 13 insertions(+), 13 deletions(-) >> >> diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c >> index 0fda515..c41a249 100644 >> --- a/net/smc/smc_clc.c >> +++ b/net/smc/smc_clc.c >> @@ -418,15 +418,15 @@ static bool smc_clc_msg_prop_valid(struct smc_clc_msg_proposal *pclc) >> return true; >> } >> -static int smc_clc_fill_fce(struct smc_clc_first_contact_ext_v2x *fce, >> +static int smc_clc_fill_fce(struct smc_clc_first_contact_ext_v2x *fce_v2x, >> struct smc_init_info *ini) > > Since this function is only used by v2.x, IMO, this function name could also be changed to e.g. smc_clc_fill_fce_v2x. Thank you, Wenjia. The function name will also be changed.
Powered by blists - more mailing lists