netdev - Re: [PATCH v5 2/3] NFSD: convert write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231129162832.4b36f96b@kernel.org>
Date: Wed, 29 Nov 2023 16:28:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: linux-nfs@...r.kernel.org, lorenzo.bianconi@...hat.com, neilb@...e.de,
 netdev@...r.kernel.org, jlayton@...nel.org
Subject: Re: [PATCH v5 2/3] NFSD: convert write_version to netlink command

On Wed, 29 Nov 2023 18:12:44 +0100 Lorenzo Bianconi wrote:
> +      -
> +        name: status
> +        type: u8

u8? I guess...

> +/**
> + * nfsd_nl_version_get_doit - Handle verion_get dumpit

doesn't match the function name (do -> dump)

> +			/* NFSv{2,3} does not support minor numbers */
> +			if (i < 4 && j)
> +				continue;
> +
> +			if (i == 4 && !nfsd_minorversion(nn, j, NFSD_TEST))
> +				continue;
> +
> +			hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid,
> +					  cb->nlh->nlmsg_seq, &nfsd_nl_family,
> +					  0, NFSD_CMD_VERSION_GET);

Why not iput()?

> +			if (!hdr)
> +				goto out;
> +
> +			if (nla_put_u32(skb, NFSD_A_SERVER_VERSION_MAJOR, i) ||
> +			    nla_put_u32(skb, NFSD_A_SERVER_VERSION_MINOR, j))
> +				goto out;
> +
> +			genlmsg_end(skb, hdr);
> +		}
> +	}