netdev - Re: [EXT] Aquantia ethernet driver suspend/resume issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262161b7-9ba9-a68c-845e-2373f58293be@marvell.com>
Date: Thu, 30 Nov 2023 13:59:14 +0100
From: Igor Russkikh <irusskikh@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Linus Torvalds <torvalds@...ux-foundation.org>,
        Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        Netdev
	<netdev@...r.kernel.org>
Subject: Re: [EXT] Aquantia ethernet driver suspend/resume issues



On 11/28/2023 10:09 PM, Jakub Kicinski wrote:
> 
> For Rx under load larger rings are sometimes useful to avoid drops.
> But your Tx rings are larger than Rx, which is a bit odd.

Agree. Just looked into the history, and it looks like this size was chosen
since the very first commit of this driver.

> I was going to say that with BQL enabled you're very unlikely to ever
> use much of the 4k Tx ring, anyway. But you don't have BQL support :S
> 
> My free advice is to recheck you really need these sizes and implement
> BQL :)

Thanks for the hint, will consider this.

Regards
  Igor