netdev - Re: [PATCH net] net/packet: move reference count in packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6568a72eab745_f2ed0294ad@willemb.c.googlers.com.notmuch>
Date: Thu, 30 Nov 2023 10:15:58 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Daniel Borkmann <daniel@...earbox.net>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 netdev@...r.kernel.org
Cc: "The UK's National Cyber Security Centre (NCSC)" <security@...c.gov.uk>, 
 stable <stable@...nel.org>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net] net/packet: move reference count in packet_sock to 64
 bits

Daniel Borkmann wrote:
> On 11/30/23 3:20 PM, Greg Kroah-Hartman wrote:
> > In some potential instances the reference count on struct packet_sock
> > could be saturated and cause overflows which gets the kernel a bit
> > confused.  To prevent this, move to a 64bit atomic reference count to
> > prevent the possibility of this type of overflow.
> > 
> > Because we can not handle saturation, using refcount_t is not possible
> > in this place.  Maybe someday in the future if it changes could it be
> > used.
> > 
> > Original version from Daniel after I did it wrong, I've provided a
> > changelog.
> > 
> > Reported-by: "The UK's National Cyber Security Centre (NCSC)" <security@...c.gov.uk>
> > Cc: stable <stable@...nel.org>
> > Cc: Daniel Borkmann <daniel@...earbox.net>
> > Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Thanks!
> 
> Acked-by: Daniel Borkmann <daniel@...earbox.net>

Acked-by: Willem de Bruijn <willemb@...gle.com>