[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iKhtEcZm4g_xykYQDjeT90EeWCWFTUDLr-T9yxr0gqH3g@mail.gmail.com>
Date: Thu, 30 Nov 2023 19:05:45 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
pabeni@...hat.com, fw@...len.de, luwei32@...wei.com, weiyongjun1@...wei.com,
yuehaibing@...wei.com
Subject: Re: [PATCH net-next] ipvlan: implemente .parse_protocol hook function
in ipvlan_header_ops
On Thu, Nov 30, 2023 at 3:50 AM Zhengchao Shao <shaozhengchao@...wei.com> wrote:
>
> The .parse_protocol hook function in the ipvlan_header_ops structure is
> not implemented. As a result, when the AF_PACKET family is used to send
> packets, skb->protocol will be set to 0.
> The IPVLAN device must be of the Ethernet type. Therefore, use
> eth_header_parse_protocol function to obtain the protocol.
>
Please add a Fixes: tag
Also, why macvlan would not need a similar patch ?
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
> drivers/net/ipvlan/ipvlan_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 57c79f5f2991..f28fd7b6b708 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -387,6 +387,7 @@ static const struct header_ops ipvlan_header_ops = {
> .parse = eth_header_parse,
> .cache = eth_header_cache,
> .cache_update = eth_header_cache_update,
> + .parse_protocol = eth_header_parse_protocol,
> };
>
> static void ipvlan_adjust_mtu(struct ipvl_dev *ipvlan, struct net_device *dev)
> --
> 2.34.1
>
Powered by blists - more mailing lists