lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231130031318.35850-1-liuhaoran14@163.com> Date: Wed, 29 Nov 2023 19:13:18 -0800 From: Haoran Liu <liuhaoran14@....com> To: davem@...emloft.net Cc: edumazet@...gle.com, pabeni@...hat.com, heiko@...ech.de, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, Haoran Liu <liuhaoran14@....com> Subject: [PATCH] [net/ethernet] arc_emac: Add error handling in emac_rockchip_probe This patch introduces error handling for the of_match_node call within the emac_rockchip_probe. Previously, there was no check for the return value of of_match_node, which could result in improper behavior if the device tree match was unsuccessful. Although the error addressed by this patch may not occur in the current environment, I still suggest implementing these error handling routines if the function is not highly time-sensitive. As the environment evolves or the code gets reused in different contexts, there's a possibility that these errors might occur. Addressing them now can prevent potential debugging efforts in the future, which could be quite resource-intensive. Signed-off-by: Haoran Liu <liuhaoran14@....com> --- drivers/net/ethernet/arc/emac_rockchip.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c index 493d6356c8ca..f6f1390b77f6 100644 --- a/drivers/net/ethernet/arc/emac_rockchip.c +++ b/drivers/net/ethernet/arc/emac_rockchip.c @@ -134,6 +134,11 @@ static int emac_rockchip_probe(struct platform_device *pdev) } match = of_match_node(emac_rockchip_dt_ids, dev->of_node); + if (!match) { + dev_err(dev, "No matching device found\n"); + return -ENODEV; + } + priv->soc_data = match->data; priv->emac.clk = devm_clk_get(dev, "hclk"); -- 2.17.1
Powered by blists - more mailing lists