lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 30 Nov 2023 12:43:31 -0800
From: Kees Cook <>
To: Trond Myklebust <>,
	Kees Cook <>
Cc: Anna Schumaker <>,
	Chuck Lever <>,
	Jeff Layton <>,
	Neil Brown <>,
	Olga Kornievskaia <>,
	Dai Ngo <>,
	Tom Talpey <>,
	"David S. Miller" <>,
	Eric Dumazet <>,
	Jakub Kicinski <>,
	Paolo Abeni <>,,,
	Azeem Shaikh <>,,
Subject: Re: [PATCH] SUNRPC: Replace strlcpy() with strscpy()

On Tue, 14 Nov 2023 09:54:18 -0800, Kees Cook wrote:
> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead
> to linear read overflows if a source string is not NUL-terminated[1].
> Additionally, it returns the size of the source string, not the
> resulting size of the destination string. In an effort to remove strlcpy()
> completely[2], replace strlcpy() here with strscpy().
> [...]

Applied to for-next/hardening, thanks!

[1/1] SUNRPC: Replace strlcpy() with strscpy()

Take care,

Kees Cook

Powered by blists - more mailing lists