lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CO1PR18MB466634805050CE390447F811A182A@CO1PR18MB4666.namprd18.prod.outlook.com> Date: Thu, 30 Nov 2023 04:36:22 +0000 From: Subbaraya Sundeep Bhatta <sbhatta@...vell.com> To: Simon Horman <horms@...nel.org> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kuba@...nel.org" <kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, "pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com" <edumazet@...gle.com>, Sunil Kovvuri Goutham <sgoutham@...vell.com>, Geethasowjanya Akula <gakula@...vell.com>, Hariprasad Kelam <hkelam@...vell.com>, Linu Cherian <lcherian@...vell.com>, Jerin Jacob Kollanukkaran <jerinj@...vell.com> Subject: RE: [EXT] Re: [PATCH v2 net] octeontx2-pf: Add missing mutex lock in otx2_get_pauseparam Hi Simon, >-----Original Message----- >From: Simon Horman <horms@...nel.org> >Sent: Wednesday, November 29, 2023 10:57 PM >To: Subbaraya Sundeep Bhatta <sbhatta@...vell.com> >Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kuba@...nel.org; >davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com; Sunil >Kovvuri Goutham <sgoutham@...vell.com>; Geethasowjanya Akula ><gakula@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>; Linu >Cherian <lcherian@...vell.com>; Jerin Jacob Kollanukkaran ><jerinj@...vell.com> >Subject: [EXT] Re: [PATCH v2 net] octeontx2-pf: Add missing mutex lock in >otx2_get_pauseparam > >External Email > >---------------------------------------------------------------------- >On Wed, Nov 29, 2023 at 10:53:42AM +0530, Subbaraya Sundeep wrote: >> All the mailbox messages sent to AF needs to be guarded by mutex lock. >> Add the missing lock in otx2_get_pauseparam function. >> >> Fixes: 75f36270990c ("octeontx2-pf: Support to enable/disable pause >> frames via ethtool") >> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com> >> --- >> v2 changes: >> Added maintainers of AF driver too > >Hi Subbaraya, > >I was expecting an update to locking in otx2_dcbnl_ieee_setpfc() Am I missing >something here? > I will send it as separate patch since both are unrelated and I have to write two Fixes in commit description. Thanks, Sundeep >Link: https://urldefense.proofpoint.com/v2/url?u=https- >3A__lore.kernel.org_all_CO1PR18MB4666C2C1D1284F425E4C9F38A183A- >40CO1PR18MB4666.namprd18.prod.outlook.com_&d=DwIBAg&c=nKjWec2b6 >R0mOyPaz7xtfQ&r=wYboOaw70DU5hRM5HDwORJx_MfD- >hXXKii2eobNikgU&m=Ds2khmm7pm9NaX3QpUwPGiIsVYvkzFPCdEKh3QVWw4 >-54ZzgzD- >KjwxrOYkhVmPj&s=q_928NBo4GzHDgDQotxtbxnd8_en9eflVGT9v8rAb9Y&e= > >> >> drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c >> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c >> index 9efcec5..53f6258 100644 >> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c >> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c >> @@ -334,9 +334,12 @@ static void otx2_get_pauseparam(struct net_device >*netdev, >> if (is_otx2_lbkvf(pfvf->pdev)) >> return; >> >> + mutex_lock(&pfvf->mbox.lock); >> req = otx2_mbox_alloc_msg_cgx_cfg_pause_frm(&pfvf->mbox); >> - if (!req) >> + if (!req) { >> + mutex_unlock(&pfvf->mbox.lock); >> return; >> + } >> >> if (!otx2_sync_mbox_msg(&pfvf->mbox)) { >> rsp = (struct cgx_pause_frm_cfg *) >> @@ -344,6 +347,7 @@ static void otx2_get_pauseparam(struct net_device >*netdev, >> pause->rx_pause = rsp->rx_pause; >> pause->tx_pause = rsp->tx_pause; >> } >> + mutex_unlock(&pfvf->mbox.lock); >> } >> >> static int otx2_set_pauseparam(struct net_device *netdev, >> -- >> 2.7.4 >>
Powered by blists - more mailing lists