netdev - Re: [PATCHv2 net-next 10/14] selftests/net: convert ioam6.sh to run it in unique namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <699fb67c-efb4-4fc9-bf18-a2ddeffbcdb7@uliege.be>
Date: Fri, 1 Dec 2023 11:49:42 +0100
From: Justin Iurman <justin.iurman@...ege.be>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
 David Ahern <dsahern@...nel.org>, linux-kselftest@...r.kernel.org,
 Po-Hsu Lin <po-hsu.lin@...onical.com>, Guillaume Nault <gnault@...hat.com>,
 Petr Machata <petrm@...dia.com>, James Prestwood <prestwoj@...il.com>,
 Jaehee Park <jhpark1013@...il.com>, Ido Schimmel <idosch@...dia.com>,
 Francesco Ruggeri <fruggeri@...sta.com>, Xin Long <lucien.xin@...il.com>,
 justin.iurman@...ege.be
Subject: Re: [PATCHv2 net-next 10/14] selftests/net: convert ioam6.sh to run
 it in unique namespace

On 12/1/23 07:43, Hangbin Liu wrote:
> On Thu, Nov 30, 2023 at 02:28:51PM +0100, Justin Iurman wrote:
>> On 11/30/23 05:01, Hangbin Liu wrote:
>>> Here is the test result after conversion.
>>>
>>> ]# ./ioam6.sh
>>>
>>> --------------------------------------------------------------------------
>>> OUTPUT tests
>>> --------------------------------------------------------------------------
>>> TEST: Unknown IOAM namespace (inline mode)                          [ OK ]
>>> TEST: Unknown IOAM namespace (encap mode)                           [ OK ]
>>> TEST: Missing trace room (inline mode)                              [ OK ]
>>> TEST: Missing trace room (encap mode)                               [ OK ]
>>> TEST: Trace type with bit 0 only (inline mode)                      [ OK ]
>>> ...
>>> TEST: Full supported trace (encap mode)                             [ OK ]
>>>
>>> --------------------------------------------------------------------------
>>> GLOBAL tests
>>> --------------------------------------------------------------------------
>>> TEST: Forward - Full supported trace (inline mode)                  [ OK ]
>>> TEST: Forward - Full supported trace (encap mode)                   [ OK ]
>>>
>>> - Tests passed: 88
>>> - Tests failed: 0
>>>
>>> Acked-by: David Ahern <dsahern@...nel.org>
>>> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
>>
>> Reviewed-by: Justin Iurman <justin.iurman@...ege.be>
>>
>> LGTM. Just one question though. Is there any reason not to use cleanup_ns
>> everywhere? There is the following diff (actually, 3 times):
> 
> Hi Justin,
> 
> Thanks for your review. There is no much intend. I just use del ns for one
> line change. And use cleanup_ns for multi line changes. I can make all
> ns delete via cleanup_ns in next version.

+1, I think it would make sense to use the new API everywhere for 
consistency.

> BTW, I will use `cleanup_ns $ns || true` in next version as cleanup_ns
> could return none 0 in PATCHv2.

Sounds good, thanks!

> Thanks
> Hangbin