netdev - RE: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB58306C2E50009A6E22F9DAD3D881A@PH0PR11MB5830.namprd11.prod.outlook.com>
Date: Fri, 1 Dec 2023 13:43:07 +0000
From: "Song, Yoong Siang" <yoong.siang.song@...el.com>
To: Jesper Dangaard Brouer <hawk@...nel.org>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
	<corbet@....net>, Bjorn Topel <bjorn@...nel.org>, "Karlsson, Magnus"
	<magnus.karlsson@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, Jonathan Lemon <jonathan.lemon@...il.com>,
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	John Fastabend <john.fastabend@...il.com>, Stanislav Fomichev
	<sdf@...gle.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Tariq Toukan
	<tariqt@...dia.com>, Willem de Bruijn <willemb@...gle.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Andrii Nakryiko <andrii@...nel.org>, "Mykola
 Lysenko" <mykolal@...com>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu
	<song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, KP Singh
	<kpsingh@...nel.org>, Hao Luo <haoluo@...gle.com>, Jiri Olsa
	<jolsa@...nel.org>, Shuah Khan <shuah@...nel.org>, Alexandre Torgue
	<alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "xdp-hints@...-project.net"
	<xdp-hints@...-project.net>, "linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>
Subject: RE: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

On Friday, December 1, 2023 6:46 PM, Jesper Dangaard Brouer <hawk@...nel.org> wrote:
>On 12/1/23 07:24, Song Yoong Siang wrote:
>> This series expands XDP TX metadata framework to include ETF HW offload.
>>
>> Changes since v1:
>> - rename Time-Based Scheduling (TBS) to Earliest TxTime First (ETF)
>> - rename launch-time to txtime
>>
>
>I strongly disagree with this renaming (sorry to disagree with Willem).
>
>The i210 and i225 chips call this LaunchTime in their programmers
>datasheets, and even in the driver code[1].
>
>Using this "txtime" name in the code is also confusing, because how can
>people reading the code know the difference between:
>  - tmo_request_timestamp and tmo_request_txtime
>

Hi Jesper and Willem,

How about using "launch_time" for the flag/variable and
"Earliest TxTime First" for the description/comments?  

Thanks & Regards
Siang

>
>[1]
>https://github.com/xdp-project/xdp-
>project/blob/master/areas/tsn/code01_follow_qdisc_TSN_offload.org
>
>> v1:
>https://patchwork.kernel.org/project/netdevbpf/cover/20231130162028.852006-1-
>yoong.siang.song@...el.com/
>>
>> Song Yoong Siang (3):
>>    xsk: add ETF support to XDP Tx metadata
>>    net: stmmac: Add txtime support to XDP ZC
>>    selftests/bpf: Add txtime to xdp_hw_metadata
>>
>>   Documentation/netlink/specs/netdev.yaml        |  4 ++++
>>   Documentation/networking/xsk-tx-metadata.rst   |  5 +++++
>>   drivers/net/ethernet/stmicro/stmmac/stmmac.h   |  2 ++
>>   .../net/ethernet/stmicro/stmmac/stmmac_main.c  | 13 +++++++++++++
>>   include/net/xdp_sock.h                         |  9 +++++++++
>>   include/net/xdp_sock_drv.h                     |  1 +
>>   include/uapi/linux/if_xdp.h                    |  9 +++++++++
>>   include/uapi/linux/netdev.h                    |  3 +++
>>   net/core/netdev-genl.c                         |  2 ++
>>   net/xdp/xsk.c                                  |  3 +++
>>   tools/include/uapi/linux/if_xdp.h              |  9 +++++++++
>>   tools/include/uapi/linux/netdev.h              |  3 +++
>>   tools/net/ynl/generated/netdev-user.c          |  1 +
>>   tools/testing/selftests/bpf/xdp_hw_metadata.c  | 18 +++++++++++++++++-
>>   14 files changed, 81 insertions(+), 1 deletion(-)
>>