netdev - Re: [PATCH ipsec-next v2 3/6] libbpf: Add BPF_CORE_WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18808a1815e76a3c3fb661ff6a588a50389b1475.camel@gmail.com>
Date: Fri, 01 Dec 2023 18:13:22 +0200
From: Eduard Zingerman <eddyz87@...il.com>
To: Daniel Xu <dxu@...uu.xyz>
Cc: ndesaulniers@...gle.com, andrii@...nel.org, nathan@...nel.org, 
 daniel@...earbox.net, ast@...nel.org, steffen.klassert@...unet.com, 
 antony.antony@...unet.com, alexei.starovoitov@...il.com,
 yonghong.song@...ux.dev,  martin.lau@...ux.dev, song@...nel.org,
 john.fastabend@...il.com,  kpsingh@...nel.org, sdf@...gle.com,
 haoluo@...gle.com, jolsa@...nel.org,  trix@...hat.com, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org,  llvm@...ts.linux.dev, devel@...ux-ipsec.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH ipsec-next v2 3/6] libbpf: Add BPF_CORE_WRITE_BITFIELD()
 macro

On Thu, 2023-11-30 at 18:33 -0700, Daniel Xu wrote:
[...]
> Good call about adding tests -- I found a few bugs with the code from
> the other thread. But boy did they take a lot of brain cells to figure
> out.
> 
> There was some 6th grade algebra involved too -- I'll do my best to
> explain it in the commit msg for v3.
> 
> Here are the fixes in case you are curious:

Ouch, I knew my code from 3am can't be trusted, sorry for that.
Your math seem to make sense, thank you.

[...]