netdev - Re: [PATCH net-next] ipvlan: implemente .parse_protocol hook function in ipvlan_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae51828e-e2fa-8cd4-0f4f-58af3590cffa@huawei.com>
Date: Fri, 1 Dec 2023 10:22:55 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: Eric Dumazet <edumazet@...gle.com>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <fw@...len.de>, <luwei32@...wei.com>,
	<weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] ipvlan: implemente .parse_protocol hook function
 in ipvlan_header_ops



On 2023/12/1 2:05, Eric Dumazet wrote:
> On Thu, Nov 30, 2023 at 3:50 AM Zhengchao Shao <shaozhengchao@...wei.com> wrote:
>>
>> The .parse_protocol hook function in the ipvlan_header_ops structure is
>> not implemented. As a result, when the AF_PACKET family is used to send
>> packets, skb->protocol will be set to 0.
>> The IPVLAN device must be of the Ethernet type. Therefore, use
>> eth_header_parse_protocol function to obtain the protocol.
>>
> 
> Please add a Fixes: tag
> 
Hi Eric:
	Thank you for your reply. I will add it in v2.
> Also, why macvlan would not need a similar patch ?
> 
   Yes, I think macvlan also need to get protocol, although the protocol
is not used in TX of the macvlan driver. I will make a patch later.

Zhengchao Shao
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> ---
>>   drivers/net/ipvlan/ipvlan_main.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
>> index 57c79f5f2991..f28fd7b6b708 100644
>> --- a/drivers/net/ipvlan/ipvlan_main.c
>> +++ b/drivers/net/ipvlan/ipvlan_main.c
>> @@ -387,6 +387,7 @@ static const struct header_ops ipvlan_header_ops = {
>>          .parse          = eth_header_parse,
>>          .cache          = eth_header_cache,
>>          .cache_update   = eth_header_cache_update,
>> +       .parse_protocol = eth_header_parse_protocol,
>>   };
>>
>>   static void ipvlan_adjust_mtu(struct ipvl_dev *ipvlan, struct net_device *dev)
>> --
>> 2.34.1
>>