netdev - Re: [net-next PATCH v10 11/11] eth: bnxt: link NAPI instances to queues and IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231130232139.25b6cba1@kernel.org>
Date: Thu, 30 Nov 2023 23:21:39 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Nambiar, Amritha" <amritha.nambiar@...el.com>
Cc: Michael Chan <michael.chan@...adcom.com>, <netdev@...r.kernel.org>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <ast@...nel.org>,
 <sdf@...gle.com>, <lorenzo@...nel.org>, <tariqt@...dia.com>,
 <daniel@...earbox.net>, <anthony.l.nguyen@...el.com>,
 <lucien.xin@...il.com>, <sridhar.samudrala@...el.com>, Andrew Gospodarek
 <gospo@...adcom.com>
Subject: Re: [net-next PATCH v10 11/11] eth: bnxt: link NAPI instances to
 queues and IRQs

On Thu, 30 Nov 2023 12:53:50 -0800 Nambiar, Amritha wrote:
> > This will include the XDP TX rings that are internal to the driver.  I
> > think we need to exclude these XDP rings and do something like this:
> > 
> > if (i > bp->tx_nr_rings_xdp)
> >          netif_queue_set_napi(bp->dev, i - bp->tx_nr_rings_xdp,
> >                               NETDEV_QUEUE_TYPE_TX, &txr->bnapi->napi);
> 
> Okay, will wait for Jakub's response as well. I can make this change in 
> the next version (after waiting for other comments on the rest of the 
> series), but I may not be able to test this on bnxt.

No extra comments from me, thanks for taking care of the update.
-- 
pw-bot: cr