netdev - Re: [PATCH net-next,v2] macvlan: implement .parse_protocol hook function in macvlan_hard_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <656b3cca535fd_1a6a2c29494@willemb.c.googlers.com.notmuch>
Date: Sat, 02 Dec 2023 09:18:50 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>, 
 netdev@...r.kernel.org, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com
Cc: weiyongjun1@...wei.com, 
 yuehaibing@...wei.com, 
 shaozhengchao@...wei.com
Subject: Re: [PATCH net-next,v2] macvlan: implement .parse_protocol hook
 function in macvlan_hard_header_ops

Zhengchao Shao wrote:
> The .parse_protocol hook function in the macvlan_header_ops structure is
> not implemented. As a result, when the AF_PACKET family is used to send
> packets, skb->protocol will be set to 0.
> Macvlan is a device of type ARPHRD_ETHER (ether_setup). Therefore, use
> eth_header_parse_protocol function to obtain the protocol.
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Macvlan does not use skb->protocol in its ndo_start_xmit often. But
does use it once, in macvlan_broadcast, to not broadcast ETH_P_PAUSE
frames.