netdev - Re: [PATCH] net: ethernet: stmmac: dwmac-rk: Repair the clock handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <334c740b-eda2-450d-b000-2ed39b86779e@lunn.ch>
Date: Sat, 2 Dec 2023 18:23:32 +0100
From: Andrew Lunn <andrew@...n.ch>
To: David Wu <david.wu@...k-chips.com>
Cc: netdev@...r.kernel.org, sebastian.reichel@...labora.com,
	davem@...emloft.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: stmmac: dwmac-rk: Repair the clock
 handling

On Sat, Dec 02, 2023 at 05:18:06PM +0800, David Wu wrote:
> It's clarier and simpler to replace devm_clk_bulk_get_optional
> via devm_clk_bulk_get_all. And it may be a different clocks
> combination for different Socs, so for the clk_mac_speed, it is
> more correct to obtain the clock directly by its name.

Is this fixing a real bug? What is that bug?

This is a big change, and it is not obviously correct. Please take a
look at the stable rules:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Could you create a minimal fix for stable, and direct this change to
net-next?


    Andrew

---
pw-bot: cr