lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231202203141.or3hyqqk2pel5nfu@google.com> Date: Sat, 2 Dec 2023 20:31:41 +0000 From: Shakeel Butt <shakeelb@...gle.com> To: Coco Li <lixiaoyan@...gle.com> Cc: Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, Mubashir Adnan Qureshi <mubashirq@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Jonathan Corbet <corbet@....net>, David Ahern <dsahern@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org, Chao Wu <wwchao@...gle.com>, Wei Wang <weiwan@...gle.com>, Pradeep Nemavat <pnemavat@...gle.com> Subject: Re: [PATCH v8 net-next 5/5] tcp: reorganize tcp_sock fast path variables On Wed, Nov 29, 2023 at 07:27:56AM +0000, Coco Li wrote: > The variables are organized according in the following way: > > - TX read-mostly hotpath cache lines > - TXRX read-mostly hotpath cache lines > - RX read-mostly hotpath cache lines > - TX read-write hotpath cache line > - TXRX read-write hotpath cache line > - RX read-write hotpath cache line > > Fastpath cachelines end after rcvq_space. > > Cache line boundaries are enforced only between read-mostly and > read-write. That is, if read-mostly tx cachelines bleed into > read-mostly txrx cachelines, we do not care. We care about the > boundaries between read and write cachelines because we want > to prevent false sharing. > > Fast path variables span cache lines before change: 12 > Fast path variables span cache lines after change: 8 > > Suggested-by: Eric Dumazet <edumazet@...gle.com> > Reviewed-by: Wei Wang <weiwan@...gle.com> > Reviewed-by: David Ahern <dsahern@...nel.org> > Signed-off-by: Coco Li <lixiaoyan@...gle.com> Reviewed-by: Shakeel Butt <shakeelb@...gle.com>
Powered by blists - more mailing lists