netdev - Re: [PATCH net-next 1/2] sfc: Implement ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231201192531.2d35fb39@kernel.org>
Date: Fri, 1 Dec 2023 19:25:31 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Alex Austin <alex.austin@....com>
Cc: <netdev@...r.kernel.org>, <linux-net-drivers@....com>,
 <ecree.xilinx@...il.com>, <habetsm.xilinx@...il.com>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <richardcochran@...il.com>, <lorenzo@...nel.org>, <memxor@...il.com>,
 <alardam@...il.com>, <bhelgaas@...gle.com>
Subject: Re: [PATCH net-next 1/2] sfc: Implement ndo_hwtstamp_(get|set)

On Thu, 30 Nov 2023 13:58:25 +0000 Alex Austin wrote:
> -	struct hwtstamp_config config;
> +	struct kernel_hwtstamp_config config;

> +	*config = efx->ptp_data->config;

Do we have a lot of places which assign the new structure directly 
like this?

There's a bit of "request state" in it:

struct kernel_hwtstamp_config {
	int flags;
	int tx_type;
	int rx_filter;
	struct ifreq *ifr;             <<<
	bool copied_to_user;           <<<
	enum hwtstamp_source source;
};

Maybe keep the type of config as was, and use
hwtstamp_config_to_kernel() to set the right fields?