netdev - Re: [PATCH net-next v3] net: ethernet: ti: davinci_mdio: Update K3 SoCs list for errata i2329

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 3 Dec 2023 07:47:32 -0600
From: Nishanth Menon <nm@...com>
To: Ravi Gunasekaran <r-gunasekaran@...com>
CC: <s-vadapalli@...com>, <rogerq@...nel.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <andrew@...n.ch>, <f.fainelli@...il.com>, <horms@...nel.org>,
        <linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <srk@...com>
Subject: Re: [PATCH net-next v3] net: ethernet: ti: davinci_mdio: Update K3
 SoCs list for errata i2329

On 18:50-20231201, Ravi Gunasekaran wrote:
> The errata i2329 affects all the currently available silicon revisions of
> AM62x, AM64x, AM65x, J7200, J721E and J721S2. So remove the revision
> string from the SoC list.
> 
> The silicon revisions affected by the errata i2329 can be found under
> the MDIO module in the "Advisories by Modules" section of each
> SoC errata document listed below
> 
> AM62x: https://www.ti.com/lit/er/sprz487c/sprz487c.pdf
> AM64X: https://www.ti.com/lit/er/sprz457g/sprz457g.pdf
> AM65X: https://www.ti.com/lit/er/sprz452i/sprz452i.pdf
> J7200: https://www.ti.com/lit/er/sprz491d/sprz491d.pdf
> J721E: https://www.ti.com/lit/er/sprz455d/sprz455d.pdf
> J721S2: https://www.ti.com/lit/er/sprz530b/sprz530b.pdf
> 
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@...com>
> ---
> Changes since v2:
> * Removed revision string for all the affected SoCs
> 
> Changes since v1:
> * For J721E, retained the incorrect SR ID and added the correct one
> * Add AM65x SR2.1 to the workaround list
> 
> v2: https://lore.kernel.org/all/20231020111738.14671-1-r-gunasekaran@ti.com/
> v1: https://lore.kernel.org/all/20231018140009.1725-1-r-gunasekaran@ti.com/
> 
>  drivers/net/ethernet/ti/davinci_mdio.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
> index 628c87dc1d28..8e07d4a1b6ba 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> @@ -511,16 +511,12 @@ static const struct k3_mdio_soc_data am65_mdio_soc_data = {
>  };
>  
>  static const struct soc_device_attribute k3_mdio_socinfo[] = {
> -	{ .family = "AM62X", .revision = "SR1.0", .data = &am65_mdio_soc_data },
> -	{ .family = "AM64X", .revision = "SR1.0", .data = &am65_mdio_soc_data },
> -	{ .family = "AM64X", .revision = "SR2.0", .data = &am65_mdio_soc_data },
> -	{ .family = "AM65X", .revision = "SR1.0", .data = &am65_mdio_soc_data },
> -	{ .family = "AM65X", .revision = "SR2.0", .data = &am65_mdio_soc_data },
> -	{ .family = "J7200", .revision = "SR1.0", .data = &am65_mdio_soc_data },
> -	{ .family = "J7200", .revision = "SR2.0", .data = &am65_mdio_soc_data },
> -	{ .family = "J721E", .revision = "SR1.0", .data = &am65_mdio_soc_data },
> -	{ .family = "J721E", .revision = "SR2.0", .data = &am65_mdio_soc_data },
> -	{ .family = "J721S2", .revision = "SR1.0", .data = &am65_mdio_soc_data},
> +	{ .family = "AM62X", .data = &am65_mdio_soc_data },
> +	{ .family = "AM64X", .data = &am65_mdio_soc_data },
> +	{ .family = "AM65X", .data = &am65_mdio_soc_data },
> +	{ .family = "J7200", .data = &am65_mdio_soc_data },
> +	{ .family = "J721E", .data = &am65_mdio_soc_data },
> +	{ .family = "J721S2", .data = &am65_mdio_soc_data },
>  	{ /* sentinel */ },


Much better. Thank you. and will avoid the conflicts we have with fixups
pending..

Reviewed-by: Nishanth Menon <nm@...com>

-- 

Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D