netdev - Re: [PATCH v7 net-next 2/8] net: ethernet: am65-cpsw: cleanup TAPRIO handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204133823.xtnmxokzwv7tehb5@skbuf>
Date: Mon, 4 Dec 2023 15:38:23 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Roger Quadros <rogerq@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, s-vadapalli@...com, r-gunasekaran@...com,
	vigneshr@...com, srk@...com, horms@...nel.org, p-varis@...com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v7 net-next 2/8] net: ethernet: am65-cpsw: cleanup TAPRIO
 handling

On Fri, Dec 01, 2023 at 03:57:56PM +0200, Roger Quadros wrote:
> Handle offloading commands using switch-case in
> am65_cpsw_setup_taprio().
> 
> Move checks to am65_cpsw_taprio_replace().
> 
> Use NL_SET_ERR_MSG_MOD for error messages.
> Change error message from "Failed to set cycle time extension"
> to "cycle time extension not supported"
> 
> Signed-off-by: Roger Quadros <rogerq@...nel.org>
> ---

After this change (I guess), it's pointless to initialize

	int ret = 0, tact = TACT_PROG;

when both will be overwritten later in am65_cpsw_taprio_replace(), and
nothing depends upon their initial values.