netdev - Re: [PATCH iproute2 3/5] tc: fq: add TCA_FQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJBZkH9CZ=+aRadPw_2TkUrp-HdiD9aEtoRyoNCjNpJVw@mail.gmail.com>
Date: Mon, 4 Dec 2023 16:55:22 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: David Ahern <dsahern@...nel.org>
Cc: Stephen Hemminger <stephen@...workplumber.org>, "David S . Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH iproute2 3/5] tc: fq: add TCA_FQ_PRIOMAP handling

On Mon, Dec 4, 2023 at 4:51 PM David Ahern <dsahern@...nel.org> wrote:
>
> On 12/4/23 2:19 AM, Eric Dumazet wrote:
> > @@ -193,6 +196,48 @@ static int fq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
> >                       pacing = 1;
> >               } else if (strcmp(*argv, "nopacing") == 0) {
> >                       pacing = 0;
> > +             } else if (strcmp(*argv, "bands") == 0) {
> > +                     int idx;
> > +
> > +                     if (set_priomap) {
> > +                             fprintf(stderr, "Duplicate \"bands\"\n");
> > +                             return -1;
> > +                     }
> > +                     memset(&prio2band, 0, sizeof(prio2band));
> > +                     NEXT_ARG();
> > +                     if (get_integer(&prio2band.bands, *argv, 10)) {
> > +                             fprintf(stderr, "Illegal \"bands\"\n");
> > +                             return -1;
> > +                     }
> > +                     if (prio2band.bands != 3) {
> > +                             fprintf(stderr, "\"bands\" must be 3\n");
> > +                             return -1;
> > +                     }
>
> do you expect number of bands to change in the future? If not, why make
> it an option or just a flag?

We do not know yet if this would in the future (we have not changed it
in the last ~9 years)

I used the same syntax as prio which would allow a future change if needed.