netdev - Re: [PATCH net-next 1/2] sfc: Implement ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204101705.1f063d03@kernel.org>
Date: Mon, 4 Dec 2023 10:17:05 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vladimir Oltean <olteanv@...il.com>
Cc: "Austin, Alex (DCCG)" <alexaust@....com>, Alex Austin
 <alex.austin@....com>, netdev@...r.kernel.org, linux-net-drivers@....com,
 ecree.xilinx@...il.com, habetsm.xilinx@...il.com, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, richardcochran@...il.com,
 lorenzo@...nel.org, memxor@...il.com, alardam@...il.com,
 bhelgaas@...gle.com
Subject: Re: [PATCH net-next 1/2] sfc: Implement ndo_hwtstamp_(get|set)

On Mon, 4 Dec 2023 13:00:35 +0200 Vladimir Oltean wrote:
> If I may intervene. The "request state" will ultimately go away once all
> drivers are converted. I know it's more fragile and not all fields are
> valid, but I think I would like drivers to store the kernel_ variant of
> the structure, because more stuff will be added to the kernel_ variant
> in the future (the hwtstamp provider + qualifier), and doing this from
> the beginning will avoid reworking them again.

Okay, you know the direction of this work better, so:

pw-bot: under-review

Report-bugs-to: Vladimir Oltean <olteanv@...il.com>

:P