[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231204102129.215e327b@kernel.org>
Date: Mon, 4 Dec 2023 10:21:29 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan
Corbet <corbet@....net>, linux-doc@...r.kernel.org, Jacob Keller
<jacob.e.keller@...el.com>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1 4/6] tools/net/ynl: Add binary and pad
support to structs for tc
On Mon, 04 Dec 2023 16:18:14 +0000 Donald Hunter wrote:
> (b) value = msg.raw[offset : offset + m.len]
>
> Happy to go with whatever preference, though maximising whitespace per
> (b) follows python style _and_ C style?
Yup, style (b) does look the least surprising to my C-accustomed eyes,
so +1 on using that.
> Also happy to make it consistent across the file (in a separate patch)?
Follow up cleanup sounds good!
Powered by blists - more mailing lists